From f7b12470dd5e5aa16366ddb25e9ff18ff6c0dae6 Mon Sep 17 00:00:00 2001 From: Thales Macedo Garitezi Date: Wed, 31 Jan 2024 15:25:03 -0300 Subject: [PATCH] test(ds): fix inter-suite flakiness Attempt to mitigate this frequent source of flakiness: ``` =CRASH REPORT==== 31-Jan-2024::17:30:15.025404 === crasher: initial call: emqx_ds_replication_layer_egress:init/1 pid: <0.11312.0> registered_name: [] exception error: no match of right hand side value {error, no_leader_for_shard} in function emqx_ds_replication_layer_egress:init/1 (/emqx/apps/emqx_durable_storage/src/emqx_ds_replication_layer_egress.erl, line 93) in call from gen_server:init_it/2 (gen_server.erl, line 980) in call from gen_server:init_it/6 (gen_server.erl, line 935) ancestors: [<0.11310.0>,<0.11304.0>,emqx_ds_builtin_databases_sup, emqx_ds_builtin_sup,emqx_ds_sup,<0.11236.0>] message_queue_len: 0 messages: [] links: [<0.11310.0>] dictionary: [] trap_exit: true status: running heap_size: 376 stack_size: 28 reductions: 231 neighbours: ``` --- .../test/emqx_ds_storage_bitfield_lts_SUITE.erl | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/apps/emqx_durable_storage/test/emqx_ds_storage_bitfield_lts_SUITE.erl b/apps/emqx_durable_storage/test/emqx_ds_storage_bitfield_lts_SUITE.erl index 03d86dd88..349eede86 100644 --- a/apps/emqx_durable_storage/test/emqx_ds_storage_bitfield_lts_SUITE.erl +++ b/apps/emqx_durable_storage/test/emqx_ds_storage_bitfield_lts_SUITE.erl @@ -406,11 +406,16 @@ all() -> emqx_common_test_helpers:all(?MODULE). suite() -> [{timetrap, {seconds, 20}}]. init_per_suite(Config) -> - {ok, _} = application:ensure_all_started(emqx_durable_storage), - Config. + Apps = emqx_cth_suite:start( + [emqx_durable_storage], + #{work_dir => emqx_cth_suite:work_dir(Config)} + ), + [{apps, Apps} | Config]. -end_per_suite(_Config) -> - ok = application:stop(emqx_durable_storage). +end_per_suite(Config) -> + Apps = ?config(apps, Config), + ok = emqx_cth_suite:stop(Apps), + ok. init_per_testcase(TC, Config) -> ok = emqx_ds:open_db(TC, ?DEFAULT_CONFIG),