From 02cb8d021148236f90754ba47a052088872c263d Mon Sep 17 00:00:00 2001 From: JianBo He Date: Wed, 27 Jan 2021 10:55:18 +0800 Subject: [PATCH] chore(style): set warnings_as_errors compile option --- apps/emqx_coap/src/emqx_coap_mqtt_adapter.erl | 2 -- rebar.config | 2 +- rebar.config.erl | 10 +++++----- src/emqx_alarm.erl | 1 - 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/apps/emqx_coap/src/emqx_coap_mqtt_adapter.erl b/apps/emqx_coap/src/emqx_coap_mqtt_adapter.erl index 48fd61a80..537f5137b 100644 --- a/apps/emqx_coap/src/emqx_coap_mqtt_adapter.erl +++ b/apps/emqx_coap/src/emqx_coap_mqtt_adapter.erl @@ -50,8 +50,6 @@ -record(state, {peername, clientid, username, password, sub_topics = [], connected_at}). --type(state() :: #state{}). - -define(ALIVE_INTERVAL, 20000). -define(CONN_STATS, [recv_pkt, recv_msg, send_pkt, send_msg]). diff --git a/rebar.config b/rebar.config index bed07d569..50ec93045 100644 --- a/rebar.config +++ b/rebar.config @@ -17,7 +17,7 @@ {extra_src_dirs, [{"etc", [{recursive,true}]}]}. {xref_checks,[undefined_function_calls,undefined_functions,locals_not_used, - deprecated_function_calls,warnings_as_errors, deprecated_functions]}. + deprecated_function_calls,warnings_as_errors,deprecated_functions]}. {dialyzer, [ {warnings, [unmatched_returns, error_handling, race_conditions]}, diff --git a/rebar.config.erl b/rebar.config.erl index 64286de12..8c9caf138 100644 --- a/rebar.config.erl +++ b/rebar.config.erl @@ -34,19 +34,19 @@ test_deps() -> ]. profiles() -> - [ {'emqx', [ {erl_opts, [no_debug_info, {parse_transform, mod_vsn}]} + [ {'emqx', [ {erl_opts, [no_debug_info, warnings_as_errors, {parse_transform, mod_vsn}]} , {relx, relx('emqx')} ]} - , {'emqx-pkg', [ {erl_opts, [no_debug_info, {parse_transform, mod_vsn}]} + , {'emqx-pkg', [ {erl_opts, [no_debug_info, warnings_as_errors, {parse_transform, mod_vsn}]} , {relx, relx('emqx-pkg')} ]} - , {'emqx-edge', [ {erl_opts, [no_debug_info, {parse_transform, mod_vsn}]} + , {'emqx-edge', [ {erl_opts, [no_debug_info, warnings_as_errors, {parse_transform, mod_vsn}]} , {relx, relx('emqx-edge')} ]} - , {'emqx-edge-pkg', [ {erl_opts, [no_debug_info, {parse_transform, mod_vsn}]} + , {'emqx-edge-pkg', [ {erl_opts, [no_debug_info, warnings_as_errors, {parse_transform, mod_vsn}]} , {relx, relx('emqx-edge-pkg')} ]} - , {check, [ {erl_opts, [debug_info, {parse_transform, mod_vsn}]} + , {check, [ {erl_opts, [debug_info, warnings_as_errors, {parse_transform, mod_vsn}]} ]} , {test, [ {deps, test_deps()} , {erl_opts, [debug_info, {parse_transform, mod_vsn}] ++ erl_opts_i()} diff --git a/src/emqx_alarm.erl b/src/emqx_alarm.erl index 9737b1463..f62e9e500 100644 --- a/src/emqx_alarm.erl +++ b/src/emqx_alarm.erl @@ -83,7 +83,6 @@ timer = undefined :: undefined | reference() }). --type state() :: #state{}. -type action() :: log | publish | event. -define(ACTIVATED_ALARM, emqx_activated_alarm).